NihalJain commented on code in PR #6385:
URL: https://github.com/apache/hbase/pull/6385#discussion_r1812084701


##########
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionFileSystem.java:
##########
@@ -184,6 +185,62 @@ public void testBlockStoragePolicy() throws Exception {
       TEST_UTIL.shutdownMiniCluster();
     }
   }
+  @Test
+  public void testMobStoreStoragePolicy() throws Exception {
+    TEST_UTIL = new HBaseTestingUtil();
+    Configuration conf = TEST_UTIL.getConfiguration();
+    TEST_UTIL.startMiniCluster();
+    Table table = TEST_UTIL.createTable(TABLE_NAME, FAMILIES);
+    assertEquals("Should start with empty table", 0, 
TEST_UTIL.countRows(table));
+    HRegionFileSystem regionFs = getHRegionFS(TEST_UTIL.getConnection(), 
table, conf);
+    try (Admin admin = TEST_UTIL.getConnection().getAdmin()) {
+      ColumnFamilyDescriptorBuilder cfdA = 
ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[0]);
+      cfdA.setValue(HStore.BLOCK_STORAGE_POLICY_KEY, "ONE_SSD");

Review Comment:
   Should we add a new key: "hbase.hmobstore.block.storage.policy"
    
   I am not sure if this JIRA is a bug or a new feature. But teh change will 
definitely change behaviour for exisdting users once this patch is merged



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to