NihalJain commented on code in PR #6384:
URL: https://github.com/apache/hbase/pull/6384#discussion_r1810911518
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/util/LoadTestKVGenerator.java:
##########
@@ -106,9 +107,11 @@ private static byte[] getValueForRowColumn(int dataSize,
byte[]... seedStrings)
seed += bytesString.hashCode();
}
}
- Random seededRandom = new Random(seed);
byte[] randomBytes = new byte[dataSize];
- seededRandom.nextBytes(randomBytes);
+ synchronized (SHARED_RANDOM) {
Review Comment:
Yes you are right, might cause slowness. Let me revert and annotate this
one..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
