NihalJain commented on code in PR #6384:
URL: https://github.com/apache/hbase/pull/6384#discussion_r1810372786


##########
hbase-diagnostics/src/main/java/org/apache/hadoop/hbase/PerformanceEvaluation.java:
##########
@@ -249,6 +249,17 @@ public String toString() {
     public int compareTo(RunResult o) {

Review Comment:
   Issue list for quick ref, lets see how many gets fixed with 1st commit:
   
   Reason | Tests
   -- | --
   SpotBugs | module:hbase-server
     | Random object created and used only once in 
org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, 
byte[][]) At LoadTestKVGenerator.java:only once in 
org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, 
byte[][]) At LoadTestKVGenerator.java:[line 111]
   SpotBugs | module:root
     | Integral division result cast to double or float in 
org.apache.hadoop.hbase.PerformanceEvaluation.calculateRowsAndSize(PerformanceEvaluation$TestOptions)
 At PerformanceEvaluation.java:double or float in 
org.apache.hadoop.hbase.PerformanceEvaluation.calculateRowsAndSize(PerformanceEvaluation$TestOptions)
 At PerformanceEvaluation.java:[line 3154]
     | org.apache.hadoop.hbase.PerformanceEvaluation$RunResult defines 
compareTo(PerformanceEvaluation$RunResult) and uses Object.equals() At 
PerformanceEvaluation.java:Object.equals() At PerformanceEvaluation.java:[line 
250]
     | Random object created and used only once in 
org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, 
byte[][]) At LoadTestKVGenerator.java:only once in 
org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, 
byte[][]) At LoadTestKVGenerator.java:[line 111]
     | org.apache.hadoop.hbase.util.LoadTestTool.DEFAULT_NUM_REGIONS_PER_SERVER 
isn't final but should be At LoadTestTool.java:be At LoadTestTool.java:[line 
167]
     | 
org.apache.hadoop.hbase.util.MultiThreadedAction.verifyResultAgainstDataGenerator(Result,
 boolean, boolean) concatenates strings using + in a loop At 
MultiThreadedAction.java:using + in a loop At MultiThreadedAction.java:[line 
415]
     | Integral division result cast to double or float in 
org.apache.hadoop.hbase.util.MultiThreadedAction$ProgressReporter.run() At 
MultiThreadedAction.java:double or float in 
org.apache.hadoop.hbase.util.MultiThreadedAction$ProgressReporter.run() At 
MultiThreadedAction.java:[line 206]
     | 
org.apache.hadoop.hbase.util.MultiThreadedReader$HBaseReaderThread.createGet(long)
 concatenates strings using + in a loop At MultiThreadedReader.java:in a loop 
At MultiThreadedReader.java:[line 318]
     | Dead store to rowKey in 
org.apache.hadoop.hbase.util.MultiThreadedReaderWithACL$HBaseReaderThreadWithACL.queryKey(Get,
 boolean, long) At 
MultiThreadedReaderWithACL.java:org.apache.hadoop.hbase.util.MultiThreadedReaderWithACL$HBaseReaderThreadWithACL.queryKey(Get,
 boolean, long) At MultiThreadedReaderWithACL.java:[line 91]
     | Inconsistent synchronization of 
org.apache.hadoop.hbase.util.MultiThreadedUpdater.writer; locked 75% of time 
Unsynchronized access at MultiThreadedUpdater.java:75% of time Unsynchronized 
access at MultiThreadedUpdater.java:[line 80]
     | Unwritten field:MultiThreadedUpdaterWithACL.java:[line 94]
     | Exception is caught when Exception is not thrown in 
org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.run(String[]) At 
WALPerformanceEvaluation.java:is not thrown in 
org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.run(String[]) At 
WALPerformanceEvaluation.java:[line 244]
     | Format string should use %n rather than n in 
org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.printUsageAndExit() At 
WALPerformanceEvaluation.java:rather than n in 
org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.printUsageAndExit() At 
WALPerformanceEvaluation.java:[line 414]
     | Exception is caught when Exception is not thrown in 
org.apache.hadoop.hbase.wal.WALPerformanceEvaluation$WALPutBenchmark.run() At 
WALPerformanceEvaluation.java:is not thrown in 
org.apache.hadoop.hbase.wal.WALPerformanceEvaluation$WALPutBenchmark.run() At 
WALPerformanceEvaluation.java:[line 171]
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to