NihalJain commented on code in PR #6384:
URL: https://github.com/apache/hbase/pull/6384#discussion_r1810383356
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/util/LoadTestKVGenerator.java:
##########
@@ -98,17 +99,17 @@ public byte[] generateRandomSizeValue(byte[]...
seedStrings) {
* Generates random bytes of the given size for the given row and column
qualifier. The random
* seed is fully determined by these parameters.
*/
- private static byte[] getValueForRowColumn(int dataSize, byte[]...
seedStrings) {
+ private synchronized static byte[] getValueForRowColumn(int dataSize,
byte[]... seedStrings) {
long seed = dataSize;
for (byte[] str : seedStrings) {
final String bytesString = Bytes.toString(str);
if (bytesString != null) {
seed += bytesString.hashCode();
}
}
- Random seededRandom = new Random(seed);
+ SHARED_RANDOM.setSeed(seed);
Review Comment:
Alternately i could just make this block sync'ed. Let me know if should do
that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
