[
https://issues.apache.org/jira/browse/GEODE-10218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534565#comment-17534565
]
ASF GitHub Bot commented on GEODE-10218:
----------------------------------------
pivotal-jbarrett commented on code in PR #954:
URL: https://github.com/apache/geode-native/pull/954#discussion_r869645866
##########
clicache/integration-test2/GfshTest.cs:
##########
@@ -77,13 +77,16 @@ public void StartLocatorStringsTest()
.withSslKeyStore("some/path/keystore.jks")
.withSslKeyStorePassword("password1")
.withSslTrustStore("some/path/truststore.jks")
- .withSslTrustStorePassword("password2");
+ .withSslTrustStorePassword("password2")
+ .withDebugAgent(true, "address");
s = locator.ToString();
+ var withAttachPortRemoved = s.Substring(0, s.LastIndexOf(":",
s.Length-1, 6));
Review Comment:
"attachPort"?
##########
cppcache/integration/framework/Cluster.h:
##########
@@ -141,6 +142,9 @@ class Cluster {
Cluster(InitialLocators initialLocators, InitialServers initialServers,
UseIpv6 useIpv6 = UseIpv6{false});
+ Cluster(InitialLocators initialLocators, InitialServers initialServers,
+ UseDebugAgent allowAttach);
Review Comment:
rename variable.
##########
cppcache/integration/framework/Cluster.h:
##########
@@ -124,6 +124,7 @@ using Password = NamedType<std::string, struct
PasswordParameter>;
using CacheXMLFiles =
NamedType<std::vector<std::string>, struct CacheXMLFilesParameter>;
using UseIpv6 = NamedType<bool, struct UseIpv6Parameter>;
+using UseDebugAgent = NamedType<bool, struct AllowAttachParameter>;
Review Comment:
Rename struct.
> Launch Cluster with Attachability Flag
> --------------------------------------
>
> Key: GEODE-10218
> URL: https://issues.apache.org/jira/browse/GEODE-10218
> Project: Geode
> Issue Type: Test
> Components: native client
> Reporter: Michael Martell
> Assignee: Michael Martell
> Priority: Minor
> Labels: pull-request-available
>
> To assist with protocol analysis it is very helpful to be able to step
> through the server code in the Intellij debugger while running native client
> test code. However, to be allowed to set breakpoints in the server code, the
> server must be started with the special flag below:
>
> --J=-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=127.0.0.1:FREEPORT
> This ticket is to add support for the above flag in the native client test
> frameworks.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
