[
https://issues.apache.org/jira/browse/GEODE-10218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519574#comment-17519574
]
ASF GitHub Bot commented on GEODE-10218:
----------------------------------------
pivotal-jbarrett commented on code in PR #954:
URL: https://github.com/apache/geode-native/pull/954#discussion_r846126196
##########
clicache/integration-test2/Cluster.cs:
##########
@@ -71,7 +73,7 @@ private bool StartLocators()
for (var i = 0; i < locatorCount_; i++)
{
var locator = new Locator(this, new List<Locator>(),
- name_ + "/locator/" + i.ToString(), i == 0);
+ name_ + "/locator/" + i.ToString(), i == 0, allowAttach_);
Review Comment:
This constructor is starting to get wild. What about a builder patter?
##########
clicache/integration-test2/Cluster.cs:
##########
@@ -200,6 +204,7 @@ public int Start()
.withMaxHeap("256m")
.withJmxManagerPort(cluster_.jmxManagerPort)
.withJmxManagerStart(startJmxManager_)
+ .withAllowAttach(allowAttach_, Address.address)
Review Comment:
What is behind the choice of the word "attach"? We are starting the debugger
agent, why not use a name that suggests that, like `withDebugAgent(...)`.
##########
clicache/integration-test2/Cluster.cs:
##########
@@ -71,7 +73,7 @@ private bool StartLocators()
for (var i = 0; i < locatorCount_; i++)
{
var locator = new Locator(this, new List<Locator>(),
Review Comment:
The second parameter here should be your `locators_` list so that each
locators is aware of the previously created.
> Launch Cluster with Attachability Flag
> --------------------------------------
>
> Key: GEODE-10218
> URL: https://issues.apache.org/jira/browse/GEODE-10218
> Project: Geode
> Issue Type: Test
> Components: native client
> Reporter: Michael Martell
> Assignee: Michael Martell
> Priority: Minor
> Labels: pull-request-available
>
> To assist with protocol analysis it is very helpful to be able to step
> through the server code in the Intellij debugger while running native client
> test code. However, to be allowed to set breakpoints in the server code, the
> server must be started with the special flag below:
>
> --J=-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=127.0.0.1:FREEPORT
> This ticket is to add support for the above flag in the native client test
> frameworks.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
