[
https://issues.apache.org/jira/browse/GEODE-10218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519598#comment-17519598
]
ASF GitHub Bot commented on GEODE-10218:
----------------------------------------
mmartell commented on code in PR #954:
URL: https://github.com/apache/geode-native/pull/954#discussion_r846170170
##########
clicache/integration-test2/Cluster.cs:
##########
@@ -71,7 +73,7 @@ private bool StartLocators()
for (var i = 0; i < locatorCount_; i++)
{
var locator = new Locator(this, new List<Locator>(),
- name_ + "/locator/" + i.ToString(), i == 0);
+ name_ + "/locator/" + i.ToString(), i == 0, allowAttach_);
Review Comment:
I do like the builder pattern. With nearly 30 potential parameters for the
start locator command it seems prudent. Means using it for Server construction
also, for consistency.
> Launch Cluster with Attachability Flag
> --------------------------------------
>
> Key: GEODE-10218
> URL: https://issues.apache.org/jira/browse/GEODE-10218
> Project: Geode
> Issue Type: Test
> Components: native client
> Reporter: Michael Martell
> Assignee: Michael Martell
> Priority: Minor
> Labels: pull-request-available
>
> To assist with protocol analysis it is very helpful to be able to step
> through the server code in the Intellij debugger while running native client
> test code. However, to be allowed to set breakpoints in the server code, the
> server must be started with the special flag below:
>
> --J=-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=127.0.0.1:FREEPORT
> This ticket is to add support for the above flag in the native client test
> frameworks.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
