[ https://issues.apache.org/jira/browse/GEODE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529577#comment-17529577 ]
ASF GitHub Bot commented on GEODE-10259: ---------------------------------------- pdxcodemonkey commented on code in PR #962: URL: https://github.com/apache/geode-native/pull/962#discussion_r861192592 ########## cppcache/src/ClientHealthStats.cpp: ########## @@ -14,62 +14,58 @@ * See the License for the specific language governing permissions and * limitations under the License. */ + #include "ClientHealthStats.hpp" -#include "CacheImpl.hpp" +#include <geode/CacheableDate.hpp> +#include <geode/DataInput.hpp> +#include <geode/DataOutput.hpp> namespace apache { namespace geode { namespace client { void ClientHealthStats::toData(DataOutput& output) const { - output.writeInt(static_cast<int32_t>(m_numGets)); - output.writeInt(static_cast<int32_t>(m_numPuts)); - output.writeInt(static_cast<int32_t>(m_numMisses)); - output.writeInt(static_cast<int32_t>(m_numCacheListenerCalls)); - output.writeInt(static_cast<int32_t>(m_numThread)); - output.writeInt(static_cast<int32_t>(m_cpus)); - output.writeInt(static_cast<int64_t>(m_processCpuTime)); - m_updateTime->toData(output); + output.writeInt(static_cast<int64_t>(gets_)); + output.writeInt(static_cast<int64_t>(puts_)); + output.writeInt(static_cast<int64_t>(misses_)); + output.writeInt(static_cast<int32_t>(cacheListenerCallsCompleted_)); + output.writeInt(static_cast<int32_t>(threads_)); + output.writeInt(static_cast<int32_t>(cpus_)); + output.writeInt(static_cast<int64_t>(processCpuTime_)); + updateTime_->toData(output); Review Comment: Okay cool - just trying to make certain you could always read the file. > Update geode-native library protocol to 1.14 > -------------------------------------------- > > Key: GEODE-10259 > URL: https://issues.apache.org/jira/browse/GEODE-10259 > Project: Geode > Issue Type: Improvement > Reporter: Jacob Barrett > Priority: Major > Labels: pull-request-available > > The geode-native library still talks the Geode 1.0.0 protocol, update to at > 1.14. -- This message was sent by Atlassian Jira (v8.20.7#820007)