[
https://issues.apache.org/jira/browse/GEODE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529571#comment-17529571
]
ASF GitHub Bot commented on GEODE-10259:
----------------------------------------
pivotal-jbarrett commented on code in PR #962:
URL: https://github.com/apache/geode-native/pull/962#discussion_r861181244
##########
cppcache/src/ClientProxyMembershipID.hpp:
##########
@@ -51,26 +46,37 @@ class ClientProxyMembershipID : public
DSMemberForVersionStamp {
const std::chrono::seconds durableClientTimeOut =
std::chrono::seconds::zero());
- // This constructor is only for testing and should not be used for any
- // other purpose. See testEntriesMapForVersioning.cpp for more details
+ /**
+ * This constructor is only for testing and should not be used for any
+ * other purpose. See testEntriesMapForVersioning.cpp for more details
+ */
ClientProxyMembershipID(const uint8_t* hostAddr, uint32_t hostAddrLen,
uint32_t hostPort, const char* dsname,
const char* uniqueTag, uint32_t vmViewId);
- // ClientProxyMembershipID(const char *durableClientId = nullptr, const
- // uint32_t durableClntTimeOut = 0);
+
ClientProxyMembershipID();
+
~ClientProxyMembershipID() noexcept override;
+
static void increaseSynchCounter();
+
static std::shared_ptr<Serializable> createDeserializable() {
return std::make_shared<ClientProxyMembershipID>();
}
- // Do an empty check on the returned value. Only use after handshake is done.
+
+ /**
+ * Do an empty check on the returned value. Only use after handshake is done.
+ */
Review Comment:
I didn't want to get that deep into refactoring this. I wanted to keep to
protocol. I just hate seeing documentation comments using the wrong comment
format. We could wack the whole comment. I will leave the refactoring of the
name and purpose up to someone else.
> Update geode-native library protocol to 1.14
> --------------------------------------------
>
> Key: GEODE-10259
> URL: https://issues.apache.org/jira/browse/GEODE-10259
> Project: Geode
> Issue Type: Improvement
> Reporter: Jacob Barrett
> Priority: Major
> Labels: pull-request-available
>
> The geode-native library still talks the Geode 1.0.0 protocol, update to at
> 1.14.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
