[
https://issues.apache.org/jira/browse/GEODE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529565#comment-17529565
]
ASF GitHub Bot commented on GEODE-10259:
----------------------------------------
pivotal-jbarrett commented on code in PR #962:
URL: https://github.com/apache/geode-native/pull/962#discussion_r861175845
##########
cppcache/integration/test/PdxJsonTypeTest.cpp:
##########
@@ -101,8 +101,7 @@ TEST(PdxJsonTypeTest, testGfshQueryJsonInstances) {
cache.createPdxInstanceFactory(gemfireJsonClassName)
.writeString("entryName", "java-domain-class-entry")
.create());
- ASSERT_THROW(execution.withArgs(query).execute("QueryFunction"),
- CacheServerException);
+ ASSERT_NO_THROW(execution.withArgs(query).execute("QueryFunction"));
Review Comment:
I don't know. The original author left no clue as to why and if that was
truly the wanted behavior. The test seems to test a few things in a single
test. The name of the test leaves little clue. I don't know why the original
was even throwing an exception here.
> Update geode-native library protocol to 1.14
> --------------------------------------------
>
> Key: GEODE-10259
> URL: https://issues.apache.org/jira/browse/GEODE-10259
> Project: Geode
> Issue Type: Improvement
> Reporter: Jacob Barrett
> Priority: Major
> Labels: pull-request-available
>
> The geode-native library still talks the Geode 1.0.0 protocol, update to at
> 1.14.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
