[
https://issues.apache.org/jira/browse/GEODE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17396211#comment-17396211
]
ASF GitHub Bot commented on GEODE-9356:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #836:
URL: https://github.com/apache/geode-native/pull/836#discussion_r685426550
##########
File path: netcore/CMakeLists.txt
##########
@@ -0,0 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+project(netcore LANGUAGES NONE)
+
+add_custom_target(netcore ALL COMMAND dotnet build WORKING_DIRECTORY =
${CMAKE_CURRENT_SOURCE_DIR}/NetCore DEPENDS apache-geode VERBATIM)
Review comment:
> Still disagree on the dependencies - IMO CMakeLists.txt dependencies
should enforce build-time dependencies _only_, and this ain't that. Either
netcore or c bindings failing will still fail the entire build, but adding the
dependency complicates the build graph and introduces potential to slow things
down or introduce bugs.
Not entirely true. Make a change to C-binding to correct or change behavior,
change .NET Core library to compensate for changes, now when you compile the
.NET Core tests to validate your new behavior it fails at runtime because you
also didn't build the C-binding. You have to go build the C-binding manually to
pick up that change then run the test. While not strictly a compile time
dependency it is a very hard runtime dependency. Even runtime dependencies
should be checked to make sure we have the correct version and since this one
is source based the correct version may require a compilation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Create CI pipeline for net-core
> -------------------------------
>
> Key: GEODE-9356
> URL: https://issues.apache.org/jira/browse/GEODE-9356
> Project: Geode
> Issue Type: Task
> Components: native client
> Reporter: Ernest Burghardt
> Priority: Major
> Labels: pull-request-available
>
> This pipeline will be hosted on the Apache publicly available Concourse and
> publish to NuGet
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
