[
https://issues.apache.org/jira/browse/GEODE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390675#comment-17390675
]
ASF GitHub Bot commented on GEODE-9356:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #836:
URL: https://github.com/apache/geode-native/pull/836#discussion_r680094997
##########
File path: netcore/CMakeLists.txt
##########
@@ -22,4 +22,7 @@ find_program(DOTNET dotnet)
if(DOTNET AND INCLUDE_DOTNET)
add_custom_target(netcore ALL COMMAND ${DOTNET} build --configuration
$<CONFIG> WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/NetCore VERBATIM)
add_custom_target(netcore-test ALL COMMAND ${DOTNET} build --configuration
$<CONFIG> WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/NetCore.Test DEPENDS
netcore VERBATIM)
+
+
+ install(FILES
${CMAKE_CURRENT_SOURCE_DIR}/NetCore/bin/$<CONFIG>/netcoreapp3.1/Apache.Geode.Netcore.dll
DESTINATION netcore/$<CONFIG>)
Review comment:
Why are we including the 'Netcore' name in our library name? We don't
include the language/platform name in any of our other library names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Create CI pipeline for net-core
> -------------------------------
>
> Key: GEODE-9356
> URL: https://issues.apache.org/jira/browse/GEODE-9356
> Project: Geode
> Issue Type: Task
> Components: native client
> Reporter: Ernest Burghardt
> Priority: Major
> Labels: pull-request-available
>
> This pipeline will be hosted on the Apache publicly available Concourse and
> publish to NuGet
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
