[ 
https://issues.apache.org/jira/browse/GEODE-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253552#comment-17253552
 ] 

ASF subversion and git services commented on GEODE-8562:
--------------------------------------------------------

Commit 5c65fc772347a38e739edfaa34f7e45454fae505 in geode-native's branch 
refs/heads/develop from Michael Martell
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=5c65fc7 ]

GEODE-8562: Adds new C++ test for using a class as a key (#714)

* Add new ClassAsKey test
* Use new classId for PositionKey (resolves conflict with existing classId)
* Make hashcode matche Java side hashcode
* Convert to C++11 style constructors (use explicit and default)
* Remove unneccessary headers
* Add explicit to constructor.
* Don't use c-style casts
* Improved variable names

Co-authored-by: Jacob Barrett <jabarr...@vmware.com>

> Add a new serialization test and example that uses a class for the key
> ----------------------------------------------------------------------
>
>                 Key: GEODE-8562
>                 URL: https://issues.apache.org/jira/browse/GEODE-8562
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Michael Martell
>            Priority: Major
>              Labels: pull-request-available
>
> There appears to be no native client tests that use a class for the key.
> A new DataSerializable test should be added (new framework of course) that 
> uses a class that implements DataSerializable for both the key and the value. 
> Also, the test should be added for both C++ and .NET.
> Also update the existing put/get examples to include using a class as the 
> key. Note, this will require Java code that instantiates the key class.
> Notes:
>  * 
>  Using a class as a key requires the equivalent Java class to be deployed, as 
> well as an Instantiator for that class to be executed by the server on 
> startup. An example of this is the 
> QueryTest::DataSerializableQueryHaveCorrectValues which uses Position.cs and 
> Position.java.
>  * In this existing test, Position.java needs to be deployed and instantiated 
> because the test executes queries. In this new test, we need to deploy and 
> instantiate the java code for the key class because it's a key not a value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to