[
https://issues.apache.org/jira/browse/GEODE-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17251188#comment-17251188
]
ASF GitHub Bot commented on GEODE-8562:
---------------------------------------
codecov-io edited a comment on pull request #714:
URL: https://github.com/apache/geode-native/pull/714#issuecomment-747534119
# [Codecov](https://codecov.io/gh/apache/geode-native/pull/714?src=pr&el=h1)
Report
> Merging
[#714](https://codecov.io/gh/apache/geode-native/pull/714?src=pr&el=desc)
(28b445c) into
[develop](https://codecov.io/gh/apache/geode-native/commit/4dd2ceb9ef0dd081039bad76cdb78a3a6cc0a2fd?el=desc)
(4dd2ceb) will **decrease** coverage by `0.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/geode-native/pull/714?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #714 +/- ##
===========================================
- Coverage 74.05% 73.98% -0.08%
===========================================
Files 642 642
Lines 50812 50812
===========================================
- Hits 37629 37592 -37
- Misses 13183 13220 +37
```
| [Impacted
Files](https://codecov.io/gh/apache/geode-native/pull/714?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[cppcache/src/ReadWriteLock.cpp](https://codecov.io/gh/apache/geode-native/pull/714/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1JlYWRXcml0ZUxvY2suY3Bw)
| `62.50% <0.00%> (-37.50%)` | :arrow_down: |
|
[...test/testThinClientPoolExecuteHAFunctionPrSHOP.cpp](https://codecov.io/gh/apache/geode-native/pull/714/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFBvb2xFeGVjdXRlSEFGdW5jdGlvblByU0hPUC5jcHA=)
| `91.20% <0.00%> (-3.71%)` | :arrow_down: |
|
[cppcache/src/PdxTypeRegistry.cpp](https://codecov.io/gh/apache/geode-native/pull/714/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1BkeFR5cGVSZWdpc3RyeS5jcHA=)
| `77.94% <0.00%> (-2.21%)` | :arrow_down: |
|
[cppcache/src/TcrEndpoint.cpp](https://codecov.io/gh/apache/geode-native/pull/714/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckVuZHBvaW50LmNwcA==)
| `53.94% <0.00%> (-0.85%)` | :arrow_down: |
|
[cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/714/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw)
| `71.11% <0.00%> (-0.51%)` | :arrow_down: |
|
[cppcache/src/LRUEntriesMap.cpp](https://codecov.io/gh/apache/geode-native/pull/714/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0xSVUVudHJpZXNNYXAuY3Bw)
| `60.08% <0.00%> (-0.43%)` | :arrow_down: |
|
[cppcache/src/ExecutionImpl.cpp](https://codecov.io/gh/apache/geode-native/pull/714/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0V4ZWN1dGlvbkltcGwuY3Bw)
| `69.92% <0.00%> (-0.40%)` | :arrow_down: |
|
[cppcache/src/ThinClientPoolDM.cpp](https://codecov.io/gh/apache/geode-native/pull/714/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sRE0uY3Bw)
| `76.24% <0.00%> (-0.36%)` | :arrow_down: |
|
[cppcache/src/ThinClientRedundancyManager.cpp](https://codecov.io/gh/apache/geode-native/pull/714/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWR1bmRhbmN5TWFuYWdlci5jcHA=)
| `75.58% <0.00%> (-0.32%)` | :arrow_down: |
|
[cppcache/src/ClientMetadataService.cpp](https://codecov.io/gh/apache/geode-native/pull/714/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NsaWVudE1ldGFkYXRhU2VydmljZS5jcHA=)
| `65.21% <0.00%> (-0.23%)` | :arrow_down: |
| ... and [1
more](https://codecov.io/gh/apache/geode-native/pull/714/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/geode-native/pull/714?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/geode-native/pull/714?src=pr&el=footer).
Last update
[4dd2ceb...c8d9a76](https://codecov.io/gh/apache/geode-native/pull/714?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a new serialization test and example that uses a class for the key
> ----------------------------------------------------------------------
>
> Key: GEODE-8562
> URL: https://issues.apache.org/jira/browse/GEODE-8562
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Michael Martell
> Priority: Major
> Labels: pull-request-available
>
> There appears to be no native client tests that use a class for the key.
> A new DataSerializable test should be added (new framework of course) that
> uses a class that implements DataSerializable for both the key and the value.
> Also, the test should be added for both C++ and .NET.
> Also update the existing put/get examples to include using a class as the
> key. Note, this will require Java code that instantiates the key class.
> Notes:
> *
> Using a class as a key requires the equivalent Java class to be deployed, as
> well as an Instantiator for that class to be executed by the server on
> startup. An example of this is the
> QueryTest::DataSerializableQueryHaveCorrectValues which uses Position.cs and
> Position.java.
> * In this existing test, Position.java needs to be deployed and instantiated
> because the test executes queries. In this new test, we need to deploy and
> instantiate the java code for the key class because it's a key not a value.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
