[
https://issues.apache.org/jira/browse/GEODE-8700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235813#comment-17235813
]
ASF GitHub Bot commented on GEODE-8700:
---------------------------------------
gaussianrecurrence commented on pull request #691:
URL: https://github.com/apache/geode-native/pull/691#issuecomment-730766998
> > Use case here is that we would like to have sort of a registry of
partition resolvers, which we define in our application and in the cache XML
file we specify which one of them we use for each partitioned region. That
would be the ideal way of doing it. This way we only need to register all the
partition resolvers we want to use.
> > Also using a shared library is a no go as the application is basically a
microservice, hence the less artifacts we have the better.
>
> I get wanting to declare them in the XML so again I don't get why need
this PR to make the region resolver mutable. If the resolver is defined in the
XML then it should work as designed.
>
> I think what your real issue is that if you have the classes defined in
your application how do you declare them in the XML if the XML config expects a
shared library name and symbol name for factory. That is something we could
easily fix. How about allowing the library name to be optional. If there is no
library name then the symbol lookup would happen in the current application
space. I think that is possible.
You are right
> > Use case here is that we would like to have sort of a registry of
partition resolvers, which we define in our application and in the cache XML
file we specify which one of them we use for each partitioned region. That
would be the ideal way of doing it. This way we only need to register all the
partition resolvers we want to use.
> > Also using a shared library is a no go as the application is basically a
microservice, hence the less artifacts we have the better.
>
> I get wanting to declare them in the XML so again I don't get why need
this PR to make the region resolver mutable. If the resolver is defined in the
XML then it should work as designed.
>
> I think what your real issue is that if you have the classes defined in
your application how do you declare them in the XML if the XML config expects a
shared library name and symbol name for factory. That is something we could
easily fix. How about allowing the library name to be optional. If there is no
library name then the symbol lookup would happen in the current application
space. I think that is possible.
Regarding mutating the partition resolver, we are on the same point, it's
not ideal, and I will abandon this approach.
Regarding looking into the application space, that's a great idea, which
I've already tested and it's working. So I will push a change with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add the ability to change the partition resolver
> ------------------------------------------------
>
> Key: GEODE-8700
> URL: https://issues.apache.org/jira/browse/GEODE-8700
> Project: Geode
> Issue Type: New Feature
> Components: native client
> Affects Versions: 1.13.0
> Reporter: Mario Salazar de Torres
> Assignee: Mario Salazar de Torres
> Priority: Major
> Labels: pull-request-available
>
> *AS A* native client contributor
> *I WANT* to be able to mutate partition resolver
> *SO THAT* I don't need to create a shared library to specify one.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
