[ 
https://issues.apache.org/jira/browse/GEODE-8700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235654#comment-17235654
 ] 

ASF GitHub Bot commented on GEODE-8700:
---------------------------------------

gaussianrecurrence commented on pull request #691:
URL: https://github.com/apache/geode-native/pull/691#issuecomment-730563953


   > I am not sure I understand the motivation. Are you saying that you want to 
define the region in `cache.xml` and then later mutate it from the API? I am 
not sure how safe this would be given the general immutable nature of the 
region objects. What is the motivation to split the configuration this way. Our 
general recommendation is to use the API over the XML configuration anyway. The 
server is moving away from the XML configuration to cluster config and API 
config. The API provides the ability to provide an instantiated by the call 
instance of the resolver where the API must use "reflection" of sorts to new 
one up so context is disconnected with the application.
   
   Use case here is that we would like to have sort of a registry of partition 
resolvers, which we define in our application and in the cache XML file we 
specify which one of them we use for each partitioned region. That would be the 
ideal way of doing it. This way we only need to register all the partition 
resolvers we want to use.
   Also using a shared library is a no go as the application is basically a 
microservice, hence the less artifacts we have the better.
   
   I was not aware of the fact that the client was also moving away from 
declarative cache definition. If that's the case, there is no argument I can 
give you that justifies allowing to mutate the partition resolver.
   
   So being that the case, unless you think there is a possibility to see this 
implemented and accepted by the community, I guess I am closing the PR?
   
   Thanks for putting some time on this!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add the ability to change the partition resolver
> ------------------------------------------------
>
>                 Key: GEODE-8700
>                 URL: https://issues.apache.org/jira/browse/GEODE-8700
>             Project: Geode
>          Issue Type: New Feature
>          Components: native client
>    Affects Versions: 1.13.0
>            Reporter: Mario Salazar de Torres
>            Assignee: Mario Salazar de Torres
>            Priority: Major
>              Labels: pull-request-available
>
> *AS A* native client contributor
> *I WANT* to be able to mutate partition resolver
> *SO THAT* I don't need to create a shared library to specify one.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to