[ 
https://issues.apache.org/jira/browse/GEODE-8700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230721#comment-17230721
 ] 

ASF GitHub Bot commented on GEODE-8700:
---------------------------------------

pivotal-jbarrett commented on pull request #691:
URL: https://github.com/apache/geode-native/pull/691#issuecomment-726158242


   @gaussianrecurrence on further inspection I have concerns about the methods 
being added to to the internal region since they only apply to partitioned 
regions. I am also concerned about the thread safety of changing the resolver 
after the region is initialized. I have added @pdxcodemonkey as a reviewer 
because I don't have the bandwidth right now to investigate this. I would also 
suggest you look at the Java implementation for inspiration. Can the Java 
version mutate the partition resolver?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add the ability to change the partition resolver
> ------------------------------------------------
>
>                 Key: GEODE-8700
>                 URL: https://issues.apache.org/jira/browse/GEODE-8700
>             Project: Geode
>          Issue Type: New Feature
>          Components: native client
>    Affects Versions: 1.13.0
>            Reporter: Mario Salazar de Torres
>            Assignee: Mario Salazar de Torres
>            Priority: Major
>              Labels: pull-request-available
>
> *AS A* native client contributor
> *I WANT* to be able to mutate partition resolver
> *SO THAT* I don't need to create a shared library to specify one.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to