[
https://issues.apache.org/jira/browse/GEODE-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234745#comment-17234745
]
ASF GitHub Bot commented on GEODE-8711:
---------------------------------------
ringles commented on a change in pull request #5749:
URL: https://github.com/apache/geode/pull/5749#discussion_r526194999
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/ParameterRequirements/SlowlogParameterRequirements.java
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.redis.internal.ParameterRequirements;
+
+import static org.apache.geode.redis.internal.RedisConstants.ERROR_NOT_INTEGER;
+import static
org.apache.geode.redis.internal.RedisConstants.ERROR_UNKNOWN_SLOWLOG_SUBCOMMAND;
+
+import org.apache.geode.redis.internal.netty.Command;
+import org.apache.geode.redis.internal.netty.ExecutionHandlerContext;
+
+public class SlowlogParameterRequirements implements ParameterRequirements {
+ @Override
+ public void checkParameters(Command command, ExecutionHandlerContext
context) {
+ int numberOfArguments = command.getProcessedCommand().size();
+
+ if (numberOfArguments < 2) {
+ throw new
RedisParametersMismatchException(command.wrongNumberOfArgumentsErrorMessage());
+ } else if (numberOfArguments == 2) {
+ confirmKnownSubcommands(command);
+ } else if (numberOfArguments == 3) {
+ confirmArgumentsToGetSubcommand(command);
+ } else if (numberOfArguments > 3) {
Review comment:
Functionally it's the same. I agree with LGTM that it's technically
redundant... but I think it's marginally more readable, making clear to a human
reading it what the intent is. Perhaps we could add a comment instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enable SLOWLOG command to support Redis monitoring tools
> --------------------------------------------------------
>
> Key: GEODE-8711
> URL: https://issues.apache.org/jira/browse/GEODE-8711
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Affects Versions: 1.14.0
> Reporter: Raymond Ingles
> Priority: Major
> Labels: pull-request-available
>
> The Redis SLOWLOG command tracks slow-executing commands. This will implement
> a placeholder to prevent errors in tools like Datadog or Redis Insights.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
