[
https://issues.apache.org/jira/browse/GEODE-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233030#comment-17233030
]
ASF GitHub Bot commented on GEODE-8711:
---------------------------------------
sabbey37 commented on a change in pull request #5749:
URL: https://github.com/apache/geode/pull/5749#discussion_r524442295
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/executor/server/SlowlogExecutor.java
##########
@@ -30,7 +27,21 @@
@Override
public RedisResponse executeCommand(Command command,
ExecutionHandlerContext context) {
- List<ByteArrayWrapper> values = new ArrayList<ByteArrayWrapper>();
- return RedisResponse.array(values);
+ String subCommand = command.getStringKey();
+ if (subCommand.toLowerCase().equals("get")) {
+ return RedisResponse.emptyArray();
+ } else if (subCommand.toLowerCase().equals("len")) {
+ return RedisResponse.integer(0);
+ } else if (subCommand.toLowerCase().equals("reset")) {
+ return RedisResponse.ok();
+ }
+ throw new
RedisParametersMismatchException(wrongNumberOfArgumentsErrorMessage());
+ }
+
+ public String wrongNumberOfArgumentsErrorMessage() {
+ String result;
+ result = String
+ .format("Unknown subcommand or wrong number of arguments for 'len'.
Try SLOWLOG HELP.");
+ return result;
Review comment:
It seems kind of weird that we have this hard coded to `len`... right
now if I type in `slowlog sjls`, I get `ERR Unknown subcommand or wrong number
of arguments for 'len'. Try SLOWLOG HELP.` instead of `ERR Unknown subcommand
or wrong number of arguments for 'sjls'. Try SLOWLOG HELP.` It also might be
good to add this Error to the `RedisConstants` class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enable SLOWLOG command to support Redis monitoring tools
> --------------------------------------------------------
>
> Key: GEODE-8711
> URL: https://issues.apache.org/jira/browse/GEODE-8711
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Affects Versions: 1.14.0
> Reporter: Raymond Ingles
> Priority: Major
> Labels: pull-request-available
>
> The Redis SLOWLOG command tracks slow-executing commands. This will implement
> a placeholder to prevent errors in tools like Datadog or Redis Insights.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
