[
https://issues.apache.org/jira/browse/GEODE-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234010#comment-17234010
]
ASF GitHub Bot commented on GEODE-8711:
---------------------------------------
ringles commented on a change in pull request #5749:
URL: https://github.com/apache/geode/pull/5749#discussion_r525539792
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/RedisCommandType.java
##########
@@ -265,6 +267,9 @@
FLUSHDB(new FlushAllExecutor(), UNSUPPORTED, new
MaximumParameterRequirements(2, ERROR_SYNTAX)),
INFO(new InfoExecutor(), UNSUPPORTED, new MaximumParameterRequirements(2,
ERROR_SYNTAX)),
SHUTDOWN(new ShutDownExecutor(), UNSUPPORTED, new
MaximumParameterRequirements(2, ERROR_SYNTAX)),
+ SLOWLOG(new SlowlogExecutor(), UNSUPPORTED, new
MinimumParameterRequirements(2)
+ .and(new MaximumParameterRequirements(3, ERROR_SYNTAX))
+ .and(new SlowlogParameterRequirements())),
Review comment:
Yeah, we refactored the validation considerably. I would agree that
using validators for specific commands should be avoided in general. But for
specific commands with unique requirements (SLOWLOG takes three subcommands,
one of which takes an optional argument, etc.) that a specific validator helps
make the code more readable. The validator has responsibility for examining the
arguments, and the executor has the responsibility for carrying out the
(pre-validated) command.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enable SLOWLOG command to support Redis monitoring tools
> --------------------------------------------------------
>
> Key: GEODE-8711
> URL: https://issues.apache.org/jira/browse/GEODE-8711
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Affects Versions: 1.14.0
> Reporter: Raymond Ingles
> Priority: Major
> Labels: pull-request-available
>
> The Redis SLOWLOG command tracks slow-executing commands. This will implement
> a placeholder to prevent errors in tools like Datadog or Redis Insights.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
