[
https://issues.apache.org/jira/browse/GEODE-8666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222988#comment-17222988
]
ASF GitHub Bot commented on GEODE-8666:
---------------------------------------
pivotal-jbarrett commented on pull request #680:
URL: https://github.com/apache/geode-native/pull/680#issuecomment-718851470
> Tangential question, what version is native client now? Geode server is
at 1.13 but is that what native client is? So to release a major version of
native client we need to wait til Geode makes a 2.0 release? That seems not
great. I've never understood why geode native and geode are release with the
same versioning scheme...
This is an ASF thing. The geode-native repository is not a separate project
or sub-project of Geode. As such its part of the Geode project and is released
with the Geode project, currently only as source, at each Geode release. So
yes, for a breaking change Geode project needs to release a major. Now this is
strict interpretation of the ASF project rules, blah blah blah... Once could
probably interpret them differently and version each module produces under the
project independently. One could define a semantic version independent of the
project version. All great discussion topics for the dev list probably.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enforce warning no-non-virtual-dtor
> -----------------------------------
>
> Key: GEODE-8666
> URL: https://issues.apache.org/jira/browse/GEODE-8666
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Michael Oleske
> Priority: Major
> Labels: pull-request-available
>
> Given I compile the code without exempting no-non-virtual-dtor
> Then it should compile
> Note - was marked as a todo
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
