[
https://issues.apache.org/jira/browse/GEODE-8666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222188#comment-17222188
]
ASF GitHub Bot commented on GEODE-8666:
---------------------------------------
gaussianrecurrence commented on pull request #680:
URL: https://github.com/apache/geode-native/pull/680#issuecomment-717956010
I am running an [ABI compliance
tool](https://lvc.github.io/abi-compliance-checker/) having compile both the
develop branch and the PR's branch and oddly it states that changes introduced
are ABI backward compatible. I will try to run the same check with Clang-6.0
and onwards so as well as win MSVC.
As stated by @pivotal-jbarrett, exposing base class destructors into vtable
should be an ABI breaking change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enforce warning no-non-virtual-dtor
> -----------------------------------
>
> Key: GEODE-8666
> URL: https://issues.apache.org/jira/browse/GEODE-8666
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Michael Oleske
> Priority: Major
> Labels: pull-request-available
>
> Given I compile the code without exempting no-non-virtual-dtor
> Then it should compile
> Note - was marked as a todo
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
