[
https://issues.apache.org/jira/browse/GEODE-8666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228766#comment-17228766
]
ASF GitHub Bot commented on GEODE-8666:
---------------------------------------
moleske commented on pull request #680:
URL: https://github.com/apache/geode-native/pull/680#issuecomment-724207520
Closing this now. Shame there wasn't a better answer to why the tool wasn't
working. I don't necessarily still agree with why ABI needs to be maintained
til a major, but I also don't care enough since I'm currently not paid to work
on this (apparently I just really like removing skipped compiler warnings
🤷♀️.) Same for making a 2.0 geode native. I'll look to set up automation on
my branch so that when a decision to make a major version happens, this can be
contributed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enforce warning no-non-virtual-dtor
> -----------------------------------
>
> Key: GEODE-8666
> URL: https://issues.apache.org/jira/browse/GEODE-8666
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Michael Oleske
> Priority: Major
> Labels: pull-request-available
>
> Given I compile the code without exempting no-non-virtual-dtor
> Then it should compile
> Note - was marked as a todo
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
