[
https://issues.apache.org/jira/browse/GEODE-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181102#comment-17181102
]
ASF GitHub Bot commented on GEODE-8119:
---------------------------------------
mkevo commented on pull request #5175:
URL: https://github.com/apache/geode/pull/5175#issuecomment-677527803
> I'm still not sure that the changes within the `DiskStoreCommandUtils`
class are needed to address the problem. I've opened a draft
[PR](https://github.com/apache/geode/pull/5463) with your test and made a
simple change within the `DiskStoreImpl` class, which seems to address this
issue more easily with less impact (see
[here](https://github.com/apache/geode/pull/5463/files#diff-05e3599f18f88368a85d5fbd987a1094L463)).
Can you have a look and let me know your thoughts?.
> I've also added some extra reviewers as they have some more knowledge
around the `disk-store` area and the related `gfsh` commands.
Hi @jujoramos ,
I agree with you and your proposal, as it will include less changes with
less impact.
I tested your changes and will create a new PR with your proposal and tests.
Thank you for a help!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Threads are not properly closed when offline disk-store commands are invoked
> ----------------------------------------------------------------------------
>
> Key: GEODE-8119
> URL: https://issues.apache.org/jira/browse/GEODE-8119
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Mario Kevo
> Assignee: Mario Kevo
> Priority: Major
> Labels: pull-request-available
>
> Threads can be opened when you are online and offline, but close only when
> you are online. Once some offline command started thread it cannot be closed
> and after some time if there is a bigger number of this threads it can lead
> to OOM exception.
> Also the problem is that its validating only disk-dirs but not diskStore
> name. So thread can be created but there is no diskStore with that name and
> it will also hang.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
