[
https://issues.apache.org/jira/browse/GEODE-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17178887#comment-17178887
]
ASF GitHub Bot commented on GEODE-8119:
---------------------------------------
mkevo commented on pull request #5175:
URL: https://github.com/apache/geode/pull/5175#issuecomment-674786552
> Hello @mkevo ,
>
> I've manually copied and executed the test
`OfflineDiskStoreCommandsDUnitTest.testThreadHangWithOfflineDiskStoreCommands()`
locally on the current `develop` branch (doesn't contain your fix for
`GEODE-8119`) and it passes just fine, so it's not actually exhibiting the bug
you intend to fix.
> As a said
[before](https://github.com/apache/geode/pull/5175#issuecomment-638793177), I'm
hesitant to approve the changes until there's at least one test showing that
the original bug exists, there's no other way to verify that the actual fix
works as intended. Once that's done, we can discuss whether the changes to
`DiskStoreCommandsUtils` should be included or not.
Hi @jujoramos ,
Please verify now, it seems that I delete writer.close by mistake so the
file was empty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Threads are not properly closed when offline disk-store commands are invoked
> ----------------------------------------------------------------------------
>
> Key: GEODE-8119
> URL: https://issues.apache.org/jira/browse/GEODE-8119
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Mario Kevo
> Assignee: Mario Kevo
> Priority: Major
> Labels: pull-request-available
>
> Threads can be opened when you are online and offline, but close only when
> you are online. Once some offline command started thread it cannot be closed
> and after some time if there is a bigger number of this threads it can lead
> to OOM exception.
> Also the problem is that its validating only disk-dirs but not diskStore
> name. So thread can be created but there is no diskStore with that name and
> it will also hang.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
