[
https://issues.apache.org/jira/browse/GEODE-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174254#comment-17174254
]
ASF GitHub Bot commented on GEODE-8119:
---------------------------------------
mkevo commented on pull request #5175:
URL: https://github.com/apache/geode/pull/5175#issuecomment-671299214
> @mkevo
> Thanks for adding the extra tests. I'm not fully convinced about the
implemented fix, however, did you consider my comments
[here](https://github.com/apache/geode/pull/5175#issuecomment-638793177)?.
Can't you just simply invoke the `DiskStoreImpl.close()` method instead of
modifying the `DiskStoreCommandsUtils` class, as it involves way less
modifications and we're sure it won't affect other areas of the `disk`
management stuff?.
I would appreciate if you can specify how to invoke this command as there is
no method like `offlineCompact` in _DiskStoreImpl.java_ for describe command
and others. The only change I made on `DiskStoreCommandsUtils` class that it
also check name, not only dirs. As if name is wrong it will start thread and
then fail without closing. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Threads are not properly closed when offline disk-store commands are invoked
> ----------------------------------------------------------------------------
>
> Key: GEODE-8119
> URL: https://issues.apache.org/jira/browse/GEODE-8119
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Mario Kevo
> Assignee: Mario Kevo
> Priority: Major
> Labels: pull-request-available
>
> Threads can be opened when you are online and offline, but close only when
> you are online. Once some offline command started thread it cannot be closed
> and after some time if there is a bigger number of this threads it can lead
> to OOM exception.
> Also the problem is that its validating only disk-dirs but not diskStore
> name. So thread can be created but there is no diskStore with that name and
> it will also hang.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
