[
https://issues.apache.org/jira/browse/GEODE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121084#comment-17121084
]
ASF GitHub Bot commented on GEODE-2484:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #607:
URL: https://github.com/apache/geode-native/pull/607#discussion_r433295688
##########
File path: cppcache/include/geode/CacheableString.hpp
##########
@@ -25,8 +25,7 @@
#include "internal/DataSerializablePrimitive.hpp"
#include "internal/geode_globals.hpp"
-/** @file
- */
+#undef max
Review comment:
C preprocessor rules suck. Something included above results in leaking a
macro from a system header defined as `max`. This then collides with
`std::max()` resulting gibberish that won't compile. I think I may have already
corrected the issue by cleaning up headers. I will pull this and see what
happens now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove ACE from native client dependencies
> ------------------------------------------
>
> Key: GEODE-2484
> URL: https://issues.apache.org/jira/browse/GEODE-2484
> Project: Geode
> Issue Type: Task
> Components: native client
> Reporter: David Kimura
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.9.0
>
> Time Spent: 11h 20m
> Remaining Estimate: 0h
>
> Remove ACE from native client dependencies.
> Replace ACE usage with C++11 and/or Boost 1.63+
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
