[
https://issues.apache.org/jira/browse/GEODE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118919#comment-17118919
]
ASF GitHub Bot commented on GEODE-2484:
---------------------------------------
pdxcodemonkey commented on a change in pull request #607:
URL: https://github.com/apache/geode-native/pull/607#discussion_r431929721
##########
File path: cppcache/src/ClientProxyMembershipIDFactory.cpp
##########
@@ -53,12 +54,13 @@
ClientProxyMembershipIDFactory::ClientProxyMembershipIDFactory(
}
std::unique_ptr<ClientProxyMembershipID>
ClientProxyMembershipIDFactory::create(
- const char* hostname, const ACE_INET_Addr& address, uint32_t hostPort,
- const char* durableClientId,
+ const std::string& durableClientId,
const std::chrono::seconds durableClntTimeOut) {
- return std::unique_ptr<ClientProxyMembershipID>(new ClientProxyMembershipID(
- dsName, randString, hostname, address, hostPort, durableClientId,
- durableClntTimeOut));
+ auto hostname = boost::asio::ip::host_name();
Review comment:
const auto?
##########
File path: cppcache/src/AdminRegion.hpp-a968f121
##########
@@ -0,0 +1,84 @@
+/*
Review comment:
What the heck is this filename about??? This looks like a leftover file
from a Git operation or something, pls delete.
##########
File path: cppcache/src/AdminRegion.hpp
##########
@@ -74,7 +73,8 @@ class AdminRegion : public
std::enable_shared_from_this<AdminRegion> {
void init();
void put(const std::shared_ptr<CacheableKey>& keyPtr,
const std::shared_ptr<Cacheable>& valuePtr);
- friend class apache::geode::statistics::HostStatSampler;
+ // friend class apache::geode::statistics::HostStatSampler;
Review comment:
Should just delete this commented line. Also hooray for removing
'friend' declaration!
##########
File path: cppcache/include/geode/CacheableString.hpp
##########
@@ -25,8 +25,7 @@
#include "internal/DataSerializablePrimitive.hpp"
#include "internal/geode_globals.hpp"
-/** @file
- */
+#undef max
Review comment:
Need some explanation here, this is really odd.
##########
File path: cppcache/src/SystemProperties.cpp
##########
@@ -88,7 +88,7 @@ constexpr auto DefaultConnectWaitTimeout =
std::chrono::seconds::zero();
constexpr auto DefaultBucketWaitTimeout = std::chrono::seconds::zero();
constexpr auto DefaultSamplingInterval = std::chrono::seconds(1);
-const bool DefaultSamplingEnabled = true;
+constexpr bool DefaultSamplingEnabled = false;
Review comment:
auto?
##########
File path: cppcache/src/CppCacheLibrary.hpp
##########
@@ -31,17 +31,28 @@ namespace client {
// initialize GEODE runtime if it has not already been initialized.
class APACHE_GEODE_EXPORT CppCacheLibrary {
public:
- // Call to this to trigger initialization.
+ /**
+ * Call to this to trigger initialization.
+ */
static void initLib(void);
Review comment:
Do we need the initLib/closeLib methods? closeLib is empty, and initLib
has one line of code. initLib is called in one place in the code base, by a
wrapper function (initLibDllEntry) that also only contains one line of code.
Said wrapper function is only called in one place, by _another_ wrapper
function (initgflib) that contains _two_ lines of code:
```
initLibDllEntry();
return true;
```
initgflib is called in, you guessed it, one place in the code, on this line
in dllmain.cpp:
```
static bool initgflibDone = initgflib();
```
initgflibDone is in turn checked in both the Windows and non-Windows
versions of the function DllMainGetPath(), but _it can never be false_(!!!)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove ACE from native client dependencies
> ------------------------------------------
>
> Key: GEODE-2484
> URL: https://issues.apache.org/jira/browse/GEODE-2484
> Project: Geode
> Issue Type: Task
> Components: native client
> Reporter: David Kimura
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.9.0
>
> Time Spent: 11h 20m
> Remaining Estimate: 0h
>
> Remove ACE from native client dependencies.
> Replace ACE usage with C++11 and/or Boost 1.63+
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
