[ https://issues.apache.org/jira/browse/GEODE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113544#comment-17113544 ]
ASF subversion and git services commented on GEODE-2484: -------------------------------------------------------- Commit f8824d2e14b704a5de6e2f5a0fc95965d9098f5b in geode-native's branch refs/heads/develop from Jacob Barrett [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=f8824d2 ] GEODE-2484: Remove ACE_Token (#594) * GEODE-2484: Removes ACE_Token Re-implement FairQueue as ConnectionQueue. * Use std::mutex. * Use std::recursive_mutex. * Add unit test * Fix clang-tidy errors Benchmark Summary: New implementation is on par with ACE version where non-recursive mutex is used. New implementation is faster where recursive mutex is used. Benchmark Results: Run on (12 X 2900 MHz CPU s) CPU Caches: L1 Data 32K (x6) L1 Instruction 32K (x6) L2 Unified 262K (x6) L3 Unified 12582K (x1) Load Average: 27.65, 20.31, 16.34 -------------------------------------------------------------------------------------------------------------------------------------------------------------------------- Benchmark Time CPU Iterations -------------------------------------------------------------------------------------------------------------------------------------------------------------------------- ConnectionQueueBM_getUntil<apache::geode::client::FairQueue<TestObject>>/192/real_time/threads:96 9.88 ns 107 ns 128204832 ConnectionQueueBM_getUntil<apache::geode::client::FairQueue<TestObject, ACE_Recursive_Thread_Mutex>>/192/real_time/threads:96 33.3 ns 365 ns 20599296 ConnectionQueueBM_getUntil<apache::geode::client::ConnectionQueue<TestObject>>/192/real_time/threads:96 10.4 ns 111 ns 127354080 ConnectionQueueBM_getUntil<apache::geode::client::ConnectionQueue<TestObject, std::recursive_mutex>>/192/real_time/threads:96 15.5 ns 174 ns 71924448 > Remove ACE from native client dependencies > ------------------------------------------ > > Key: GEODE-2484 > URL: https://issues.apache.org/jira/browse/GEODE-2484 > Project: Geode > Issue Type: Task > Components: native client > Reporter: David Kimura > Priority: Major > Labels: pull-request-available > Fix For: 1.9.0 > > Time Spent: 11h 20m > Remaining Estimate: 0h > > Remove ACE from native client dependencies. > Replace ACE usage with C++11 and/or Boost 1.63+ -- This message was sent by Atlassian Jira (v8.3.4#803005)