[
https://issues.apache.org/jira/browse/GEODE-8039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099210#comment-17099210
]
ASF GitHub Bot commented on GEODE-8039:
---------------------------------------
metatype commented on a change in pull request #5018:
URL: https://github.com/apache/geode/pull/5018#discussion_r419626110
##########
File path: LICENSE
##########
@@ -280,8 +280,6 @@ Apache Geode bundles the following files under the MIT
license:
Foundation and other contributors, http://jquery.org
- jScrollPane (http://jscrollpane.kelvinluck.com/), Copyright (c) 2010
Kelvin Luck
- - matchMedia() polyfill (https://github.com/paulirish/matchMedia.js),
Review comment:
Why is this removed? I believe one of the js libraries that we include
has bundled this in their source code. See
https://lists.apache.org/thread.html/ef3c70fcae89a05adbc46598439208a2e920d71b4f7062662a814fff%401460088338%40%3Cdev.geode.apache.org%3E.
##########
File path:
buildSrc/src/main/groovy/org/apache/geode/gradle/plugins/DependencyConstraints.groovy
##########
@@ -101,6 +101,7 @@ class DependencyConstraints implements Plugin<Project> {
api(group: 'com.nimbusds', name:'nimbus-jose-jwt', version:'8.11')
api(group: 'com.sun.activation', name: 'javax.activation', version:
'1.2.0')
api(group: 'com.sun.istack', name: 'istack-commons-runtime', version:
'3.0.11')
+ api(group: 'com.sun.mail', name: 'javax.mail', version: '1.6.2')
Review comment:
Why is this removed?
##########
File path: geode-assembly/src/main/dist/LICENSE
##########
@@ -1053,14 +1095,12 @@ Apache Geode bundles the following files under the MIT
license:
Foundation and other contributors, http://jquery.org
- jScrollPane (http://jscrollpane.kelvinluck.com/), Copyright (c) 2010
Kelvin Luck
- - matchMedia() polyfill (https://github.com/paulirish/matchMedia.js),
Review comment:
This should stay, see above.
##########
File path: geode-assembly/src/main/dist/LICENSE
##########
@@ -261,17 +263,18 @@ POSSIBILITY OF SUCH DAMAGE.
The CDDL Version 1.1 (https://javaee.github.io/glassfish/LICENSE)
---------------------------------------------------------------------------
-Apache Geode bundles the following file under the Common Development and
+Apache Geode bundles the following files under the Common Development and
Distribution License:
- - jaxb-istack-commons v2.2 (https://javaee.github.io/jaxb-istack-commons/)
+ - activation v1.1.0
Review comment:
Something seems wrong that we are bundling both activation and
Java.activation. Can you file a JIRA for followup?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> update LICENSE for 1.13
> -----------------------
>
> Key: GEODE-8039
> URL: https://issues.apache.org/jira/browse/GEODE-8039
> Project: Geode
> Issue Type: Improvement
> Components: release
> Reporter: Owen Nichols
> Priority: Major
>
> ensure all dependencies we bundle with src distribution are correctly listed
> in LICENSE and all dependencies bundled in binary distribution are correctly
> listed in geode-assembly/src/main/dist/LICENSE
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
