[
https://issues.apache.org/jira/browse/GEODE-8039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099334#comment-17099334
]
ASF GitHub Bot commented on GEODE-8039:
---------------------------------------
onichols-pivotal commented on a change in pull request #5018:
URL: https://github.com/apache/geode/pull/5018#discussion_r419706638
##########
File path: gradle/java.gradle
##########
@@ -73,9 +73,9 @@ gradle.taskGraph.whenReady({ graph ->
}
}
jar.metaInf {
- from("$rootDir/LICENSE")
+ from("$rootDir/geode-assembly/src/main/dist/LICENSE")
if (jar.source.filter({ it.name.contains('NOTICE') }).empty) {
- from("$rootDir/NOTICE")
+ from("$rootDir/geode-assembly/src/main/dist/NOTICE")
Review comment:
I think gradle treats .war and .jar files as equivalent for applying
this clause. Maybe @rhoughton-pivot can offer some more insight. I confess my
understand of what NOTICE goes where is not as clear as my understanding of
LICENSE...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> update LICENSE for 1.13
> -----------------------
>
> Key: GEODE-8039
> URL: https://issues.apache.org/jira/browse/GEODE-8039
> Project: Geode
> Issue Type: Improvement
> Components: release
> Reporter: Owen Nichols
> Priority: Major
>
> ensure all dependencies we bundle with src distribution are correctly listed
> in LICENSE and all dependencies bundled in binary distribution are correctly
> listed in geode-assembly/src/main/dist/LICENSE
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
