[
https://issues.apache.org/jira/browse/GEODE-3412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125278#comment-16125278
]
ASF GitHub Bot commented on GEODE-3412:
---------------------------------------
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/707#discussion_r132878512
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
---
@@ -72,9 +99,15 @@ public static ServerConnection
makeServerConnection(Socket s, InternalCache c,
throw new IOException("Acceptor received unknown communication
mode: " + communicationMode);
} else {
protobufProtocolHandler = findClientProtocolMessageHandler();
- return new GenericProtocolServerConnection(s, c, helper, stats,
hsTimeout, socketBufferSize,
- communicationModeStr, communicationMode, acceptor,
protobufProtocolHandler,
- securityService);
+ authenticatorClass = findStreamAuthenticator(
+
c.getInternalDistributedSystem().getConfig().getProtobufProtocolAuthenticationMode());
+ try {
+ return new GenericProtocolServerConnection(s, c, helper, stats,
hsTimeout,
+ socketBufferSize, communicationModeStr, communicationMode,
acceptor,
+ protobufProtocolHandler, securityService,
authenticatorClass.newInstance());
--- End diff --
We find the class exactly once, and create a new instance per protocol
instance. We then create an instance per `GenericProtocolServerConnection`.
This is because the authenticator (unlike the protocol handler) is stateful, so
we can't share it between connections.
> Implement a basic authentication mechanism for the new protocol
> ---------------------------------------------------------------
>
> Key: GEODE-3412
> URL: https://issues.apache.org/jira/browse/GEODE-3412
> Project: Geode
> Issue Type: New Feature
> Components: client/server
> Reporter: Brian Rowe
>
> Implement a simple username/password authentication for the new protocol.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
