[
https://issues.apache.org/jira/browse/GEODE-3412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125275#comment-16125275
]
ASF GitHub Bot commented on GEODE-3412:
---------------------------------------
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/707#discussion_r132878378
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
---
@@ -63,6 +65,31 @@ private static ClientProtocolMessageHandler
findClientProtocolMessageHandler() {
}
}
+ private static Class<? extends StreamAuthenticator>
findStreamAuthenticator(
+ String implementationID) {
+ if (authenticatorClass != null) {
+ return authenticatorClass;
+ }
+
+ synchronized (streamAuthenticatorLoadLock) {
--- End diff --
Once `authenticatorClass` is initialized, there will no longer be any
synchronization necessary in this method. This means that each thread will need
to synchronize at most once, which means no locking / cache misses.
> Implement a basic authentication mechanism for the new protocol
> ---------------------------------------------------------------
>
> Key: GEODE-3412
> URL: https://issues.apache.org/jira/browse/GEODE-3412
> Project: Geode
> Issue Type: New Feature
> Components: client/server
> Reporter: Brian Rowe
>
> Implement a simple username/password authentication for the new protocol.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
