[
https://issues.apache.org/jira/browse/GEODE-3412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125274#comment-16125274
]
ASF GitHub Bot commented on GEODE-3412:
---------------------------------------
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/707#discussion_r132878110
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfig.java
---
@@ -2433,6 +2433,25 @@
String getRedundancyZone();
/**
+ * @since Geode 1.??? TODO FIXME
+ */
+ @ConfigAttribute(type = String.class)
+ String PROTOBUF_PROTOCOL_AUTHENTICATION_MODE_NAME =
PROTOBUF_PROTOCOL_AUTHENTICATION_MODE;
+ String DEFAULT_PROTOBUF_PROTOCOL_AUTHENTICATION_MODE = "NOOP";
+
+ /**
+ * @since Geode 1.??? TODO FIXME
+ */
+ @ConfigAttributeSetter(name = PROTOBUF_PROTOCOL_AUTHENTICATION_MODE)
+ void setProtobufProtocolAuthenticationMode(String authenticationMode);
+
+ /**
+ * @since Geode 1.??? TODO FIXME
+ */
+ @ConfigAttributeGetter(name = PROTOBUF_PROTOCOL_AUTHENTICATION_MODE)
+ String getProtobufProtocolAuthenticationMode();
+
+ /**
--- End diff --
That's a reasonable choice. Do you think this should be another
undocumented system property? It might be fine for an alpha, but I don't think
we should do it for long after that.
> Implement a basic authentication mechanism for the new protocol
> ---------------------------------------------------------------
>
> Key: GEODE-3412
> URL: https://issues.apache.org/jira/browse/GEODE-3412
> Project: Geode
> Issue Type: New Feature
> Components: client/server
> Reporter: Brian Rowe
>
> Implement a simple username/password authentication for the new protocol.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
