Dpk376 opened a new pull request, #5668: URL: https://github.com/apache/fineract/pull/5668
## Description Closes/relates to [FINERACT-2454](https://issues.apache.org/jira/browse/FINERACT-2454) Migrates `LoanWithdrawnByApplicantIntegrationTest` from RestAssured to the type-safe feign client, as part of the ongoing test migration effort. ## Changes - Replaced `RequestSpecification`/`ResponseSpecification` boilerplate with `extends BaseLoanIntegrationTest` - Removed `@BeforeEach` setup — lifecycle managed by `BaseLoanIntegrationTest` - Replaced `ClientHelper.createClient(requestSpec, responseSpec, ...)` → `ClientHelper.createClient(PostClientsRequest)` - Replaced `LoanProductTestBuilder` → `createOnePeriod30DaysLongNoInterestPeriodicAccrualProduct()` - Replaced `LoanApplicationTestBuilder` + `CollateralManagementHelper` (no feign equivalent) → `applyLoan(applyLoanRequest(...))` - Replaced `LoanStatusChecker` HashMap-based assertions → `verifyLoanStatus(loanId, LoanStatus.*)` - Replaced `withdrawLoanApplicationByClient()` → `withdrawnByApplicantLoan(externalId, PostLoansLoanIdRequest)` ## Result 102 lines → 60 lines. Zero RestAssured imports remaining. No behavioral changes — the test still verifies that a pending loan application can be withdrawn by the applicant and transitions to `WITHDRAWN_BY_CLIENT` status. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
