Saifulhuq01 commented on code in PR #5668:
URL: https://github.com/apache/fineract/pull/5668#discussion_r2970845259


##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/ClientHelper.java:
##########
@@ -111,6 +114,58 @@ public static PostClientsResponse createClient(final 
PostClientsRequest request)
         return 
Calls.ok(FineractClientHelper.getFineractClient().clients.createClient(request));
     }
 
+    public static PostClientsResponse addClientAsPerson(final String officeId, 
final Long legalFormId, final String externalId) {
+        PostClientsRequest request = new 
PostClientsRequest().officeId(officeId != null ? Long.parseLong(officeId) : 1L)
+                
.legalFormId(legalFormId).firstname(Utils.randomFirstNameGenerator()).lastname(Utils.randomLastNameGenerator())
+                
.externalId(externalId).dateFormat(Utils.DATE_FORMAT).locale("en").active(true).activationDate(DEFAULT_DATE);
+        return createClient(request);
+    }
+
+    public static GetClientsClientIdResponse getClientByExternalId(final 
String externalId) {
+        return 
Calls.ok(FineractClientHelper.getFineractClient().clients.retrieveOneClientByExternalId(externalId,
 null));
+    }
+
+    public static PutClientsClientIdResponse updateClientByExternalId(final 
String externalId, final PutClientsClientIdRequest request) {
+        return 
Calls.ok(FineractClientHelper.getFineractClient().clients.updateClientByExternalId(externalId,
 request));
+    }
+
+    public static DeleteClientsClientIdResponse deleteClientByExternalId(final 
String externalId) {
+        return 
Calls.ok(FineractClientHelper.getFineractClient().clients.deleteClientByExternalId(externalId));
+    }
+
+    public static GetClientsClientIdAccountsResponse getClientAccounts(final 
String externalId) {
+        return 
Calls.ok(FineractClientHelper.getFineractClient().clients.retrieveAllClientAccountsByExternalId(externalId));
+    }
+
+    public static GetClientTransferProposalDateResponse 
getProposedTransferDate(final String externalId) {
+        return 
Calls.ok(FineractClientHelper.getFineractClient().clients.retrieveClientTransferTemplateByExternalId(externalId));
+    }
+
+    // public static List<GetObligeeData> getObligeeData(final String 
externalId) {
+    //     GetClientObligeeDetailsResponse response = Calls
+    //             
.ok(FineractClientHelper.getFineractClient().clients.retrieveClientObligeeDetailsByExternalId(externalId));
+    //     return response != null && response.getObligees() != null ? new 
ArrayList<>(response.getObligees()) : new ArrayList<>();
+    // }
+
+    public static List<GetObligeeData> getObligeeData(final String externalId) 
{
+    // Note: The Feign-generated client incorrectly maps this endpoint to 
GetClientObligeeDetailsResponse (object),
+    // but the actual API returns a JSON array directly. Using RestAssured as 
a workaround until the OpenAPI spec is corrected.

Review Comment:
   please..



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to