devi-pathak2263 opened a new pull request, #5667: URL: https://github.com/apache/fineract/pull/5667
## Description Fixes an issue where unsupported templateType values in retrieveApprovalTemplate(...) returned a null/empty response instead of throwing an error. ## Changes - Added explicit validation for unsupported templateType - Throws NotSupportedLoanTemplateTypeException for invalid values ## Impact - Prevents silent failures - Aligns behavior with other template APIs - Improves API consistency ## Additional Notes This change aligns with existing usage of NotSupportedLoanTemplateTypeException in other template-related methods within LoansApiResource and ensures consistent error handling across APIs.. ## JIRA: https://issues.apache.org/jira/browse/FINERACT-2550 ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
