uvoigt commented on code in PR #765:
URL: https://github.com/apache/commons-compress/pull/765#discussion_r3008699730
##########
src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveOutputStream.java:
##########
@@ -929,7 +1134,7 @@ public void finish() throws IOException {
}
if (entry != null) {
- throw new ArchiveException("This archive contains unclosed
entries.");
+ closeArchiveEntry();
Review Comment:
It is tested in [testAutoCompressZstd(ZipMethod
zipMethod)](https://github.com/apache/commons-compress/pull/765/changes#diff-540c440c3632bdafdb31449fccac357441aae5f8fd8689e8a17922a4e6caf7bdR43)
for `auto-compress` and in
[testAutoCompressFalsePreservesLegacyBehavior()](https://github.com/apache/commons-compress/pull/765/changes#diff-540c440c3632bdafdb31449fccac357441aae5f8fd8689e8a17922a4e6caf7bd)
for user specified compressing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
