mehmet-karaman commented on code in PR #765:
URL: https://github.com/apache/commons-compress/pull/765#discussion_r3008654655


##########
src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveOutputStream.java:
##########
@@ -929,7 +1134,7 @@ public void finish() throws IOException {
         }
 
         if (entry != null) {
-            throw new ArchiveException("This archive contains unclosed 
entries.");
+            closeArchiveEntry();

Review Comment:
   We can close this.. There was a todo in the ArchiveOutputStreamTest which is 
resolved by this change, so it was somehow planned to do..



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to