mehmet-karaman commented on code in PR #765:
URL: https://github.com/apache/commons-compress/pull/765#discussion_r3008423250
##########
src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveOutputStream.java:
##########
@@ -929,7 +1134,7 @@ public void finish() throws IOException {
}
if (entry != null) {
- throw new ArchiveException("This archive contains unclosed
entries.");
+ closeArchiveEntry();
Review Comment:
To keep the API compatible with older clients, wouldn’t it be better to
execute this only when the isAutoCompressed flag is set and otherwise still
throw the exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
