tabish121 commented on code in PR #6268:
URL: https://github.com/apache/artemis/pull/6268#discussion_r2875217968
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java:
##########
@@ -359,6 +399,35 @@ public synchronized void shutdown() throws Exception {
}
}
+ @Override
+ public synchronized void pause() throws Exception {
Review Comment:
I don't really see any benefit to having public pause / resume in the broker
connection API and would instead make these private. The BrokerConnection
already has initialize, start, stop and shutdown and those a pretty clear,
adding pause and resume there doesn't make a ton of sense and they aren't
currently documented to tell an implementation how or why they are different
from start and stop. Nor are they used anywhere outside of the AMQP broker
connection itself at present and don't seem to have an actual use outside of it
either..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
