tabish121 commented on code in PR #6268:
URL: https://github.com/apache/artemis/pull/6268#discussion_r2873101384
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java:
##########
@@ -359,6 +397,37 @@ public synchronized void shutdown() throws Exception {
}
}
+ @Override
Review Comment:
The broker connection already has start / stop and shutdown where stop and
start are effectively already a start of managing this kind of state so adding
these just becomes confusing. These methods would also need synchronization if
added in the same manner as the start and stop correctly do now to prevent
overlapping calls corrupting state while trigger start and stop
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/BrokerConnection.java:
##########
@@ -32,6 +33,24 @@ default void shutdown() throws Exception {
// Subclass should override and perform needed cleanup.
}
+ default void pause() throws Exception {
Review Comment:
Start and Stop are already here to manage this state, pause and resume just
confuse matters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
