clebertsuconic commented on code in PR #6268:
URL: https://github.com/apache/artemis/pull/6268#discussion_r2875365876


##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java:
##########
@@ -359,6 +399,35 @@ public synchronized void shutdown() throws Exception {
       }
    }
 
+   @Override
+   public synchronized void pause() throws Exception {

Review Comment:
   I have removed it now as I'm not using it.. but pause != stop...
   
   when you pause (from the POV of mirroring) you stop capturing events...
   
   when you stop, you close connections, but you leave the interceptor in place 
until the broker goes away... otherwise you may lose messages.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to