tabish121 commented on code in PR #6268:
URL: https://github.com/apache/artemis/pull/6268#discussion_r2872990960
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/bridge/AMQPBridgeManagers.java:
##########
@@ -57,6 +57,12 @@ public void shutdown() {
bridgeManagers.clear();
}
+ public void pause() {
Review Comment:
You don't need these, as the component already has start and stop which
safely close down the resources
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/federation/AMQPFederationSource.java:
##########
@@ -138,6 +138,12 @@ public synchronized AMQPConnectionContext
getConnectionContext() {
return connection;
}
+ public void pause() {
Review Comment:
You don't need these, as the component already has start and stop which
safely close down the resources
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/federation/AMQPFederation.java:
##########
@@ -108,6 +108,12 @@ public AMQPFederation(String name, ActiveMQServer server) {
}
}
+ public void pause() throws Exception {
Review Comment:
You don't need these, as the component already has start and stop which
safely close down the resources
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
