WillAyd opened a new issue, #46309:
URL: https://github.com/apache/arrow/issues/46309
### Describe the enhancement requested
In the meson configuration, a lot of warnings are thrown by
-Wignored-qualifiers:
These should be easy to clean up, and I think would be good to add this to
the main CMake configuration as well:
```
../src/arrow/compute/kernels/scalar_temporal_unary.cc: In member function ‘T
arrow::compute::internal::{anonymous}::Year<Duration,
Localizer>::Call(arrow::compute::KernelContext*, Arg0, arrow::Status*) const’:
../src/arrow/compute/kernels/scalar_temporal_unary.cc:196:27: warning: type
qualifiers ignored on cast result type [-Wignored-qualifiers]
196 | return static_cast<T>(static_cast<const int32_t>(
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
197 | year_month_day(floor<days>(localizer_.template
ConvertTimePoint<Duration>(arg)))
|
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
198 | .year()));
| ~~~~~~~~
../src/arrow/compute/kernels/scalar_temporal_unary.cc: In member function ‘T
arrow::compute::internal::{anonymous}::IsLeapYear<Duration,
Localizer>::Call(arrow::compute::KernelContext*, Arg0, arrow::Status*) const’:
../src/arrow/compute/kernels/scalar_temporal_unary.cc:214:17: warning: type
qualifiers ignored on cast result type [-Wignored-qualifiers]
214 | int32_t y = static_cast<const int32_t>(
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
215 | year_month_day(floor<days>(localizer_.template
ConvertTimePoint<Duration>(arg)))
|
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
216 | .year());
| ~~~~~~~~
../src/arrow/compute/kernels/scalar_temporal_unary.cc: In member function ‘T
arrow::compute::internal::{anonymous}::Month<Duration,
Localizer>::Call(arrow::compute::KernelContext*, Arg0, arrow::Status*) const’:
../src/arrow/compute/kernels/scalar_temporal_unary.cc:233:27: warning: type
qualifiers ignored on cast result type [-Wignored-qualifiers]
233 | return static_cast<T>(static_cast<const uint32_t>(
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
234 | year_month_day(floor<days>(localizer_.template
ConvertTimePoint<Duration>(arg)))
|
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
235 | .month()));
| ~~~~~~~~~
../src/arrow/compute/kernels/scalar_temporal_unary.cc: In member function ‘T
arrow::compute::internal::{anonymous}::Day<Duration,
Localizer>::Call(arrow::compute::KernelContext*, Arg0, arrow::Status*) const’:
../src/arrow/compute/kernels/scalar_temporal_unary.cc:251:27: warning: type
qualifiers ignored on cast result type [-Wignored-qualifiers]
251 | return static_cast<T>(static_cast<const uint32_t>(
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
252 | year_month_day(floor<days>(localizer_.template
ConvertTimePoint<Duration>(arg)))
|
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
253 | .day()));
| ~~~~~~~
../src/arrow/compute/kernels/scalar_temporal_unary.cc: In function
‘std::array<long int, 3>
arrow::compute::internal::{anonymous}::GetYearMonthDay(int64_t, Localizer&&)’:
../src/arrow/compute/kernels/scalar_temporal_unary.cc:267:32: warning: type
qualifiers ignored on cast result type [-Wignored-qualifiers]
267 | return {static_cast<int64_t>(static_cast<const
int32_t>(ymd.year())),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/arrow/compute/kernels/scalar_temporal_unary.cc:268:32: warning: type
qualifiers ignored on cast result type [-Wignored-qualifiers]
268 | static_cast<int64_t>(static_cast<const
uint32_t>(ymd.month())),
|
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/arrow/compute/kernels/scalar_temporal_unary.cc:269:32: warning: type
qualifiers ignored on cast result type [-Wignored-qualifiers]
269 | static_cast<int64_t>(static_cast<const
uint32_t>(ymd.day()))};
```
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
