WillAyd opened a new issue, #46310:
URL: https://github.com/apache/arrow/issues/46310
### Describe the enhancement requested
The meson configuration issues some warnings from the -Wself-move option.
These should be pretty easy to clean up, and I think would be good to add to
the main CMake configuration:
```
../src/arrow/util/small_vector_test.cc: In instantiation of ‘void
arrow::internal::TestSmallStaticVector<Param>::CheckMove(bool) [with long
unsigned int N = 5; Param =
arrow::internal::VectorIntLikeParam<arrow::internal::StaticVectorTraits,
arrow::MoveOnlyDataType>]’:
../src/arrow/util/small_vector_test.cc:423:38: required from ‘void
arrow::internal::TestSmallStaticVector<Param>::TestMove() [with Param =
arrow::internal::VectorIntLikeParam<arrow::internal::StaticVectorTraits,
arrow::MoveOnlyDataType>]’
../src/arrow/util/small_vector_test.cc:762:57: required from ‘void
arrow::internal::TestSmallStaticVector_Move_Test<gtest_TypeParam_>::TestBody()
[with gtest_TypeParam_ =
arrow::internal::VectorIntLikeParam<arrow::internal::StaticVectorTraits,
arrow::MoveOnlyDataType>]’
../src/arrow/util/small_vector_test.cc:762:1: required from here
../src/arrow/util/small_vector_test.cc:417:22: warning: moving
‘moved_moved_ints’ of type
‘arrow::internal::TestSmallStaticVector<arrow::internal::VectorIntLikeParam<arrow::internal::StaticVectorTraits,
arrow::MoveOnlyDataType> >::IntVectorType<5>’ {aka
‘arrow::internal::StaticVectorImpl<arrow::MoveOnlyDataType, 5,
arrow::internal::StaticVectorStorage<arrow::MoveOnlyDataType, 5, true> >’} to
itself [-Wself-move]
417 | moved_moved_ints = std::move(moved_moved_ints);
| ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/arrow/util/small_vector_test.cc:417:22: note: remove ‘std::move’ call
../src/arrow/util/small_vector_test.cc: In instantiation of ‘void
arrow::internal::TestSmallStaticVector<Param>::CheckMove(bool) [with long
unsigned int N = 2; Param =
arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits, int>]’:
../src/arrow/util/small_vector_test.cc:423:38: required from ‘void
arrow::internal::TestSmallStaticVector<Param>::TestMove() [with Param =
arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits, int>]’
../src/arrow/util/small_vector_test.cc:762:57: required from ‘void
arrow::internal::TestSmallStaticVector_Move_Test<gtest_TypeParam_>::TestBody()
[with gtest_TypeParam_ =
arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits, int>]’
../src/arrow/util/small_vector_test.cc:762:1: required from here
../src/arrow/util/small_vector_test.cc:417:22: warning: moving
‘moved_moved_ints’ of type
‘arrow::internal::TestSmallStaticVector<arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits,
int> >::IntVectorType<2>’ {aka ‘arrow::internal::StaticVectorImpl<int, 2,
arrow::internal::SmallVectorStorage<int, 2> >’} to itself [-Wself-move]
../src/arrow/util/small_vector_test.cc:417:22: note: remove ‘std::move’ call
../src/arrow/util/small_vector_test.cc: In instantiation of ‘void
arrow::internal::TestSmallStaticVector<Param>::CheckMove(bool) [with long
unsigned int N = 5; Param =
arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits, int>]’:
../src/arrow/util/small_vector_test.cc:424:17: required from ‘void
arrow::internal::TestSmallStaticVector<Param>::TestMove() [with Param =
arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits, int>]’
../src/arrow/util/small_vector_test.cc:762:57: required from ‘void
arrow::internal::TestSmallStaticVector_Move_Test<gtest_TypeParam_>::TestBody()
[with gtest_TypeParam_ =
arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits, int>]’
../src/arrow/util/small_vector_test.cc:762:1: required from here
../src/arrow/util/small_vector_test.cc:417:22: warning: moving
‘moved_moved_ints’ of type
‘arrow::internal::TestSmallStaticVector<arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits,
int> >::IntVectorType<5>’ {aka ‘arrow::internal::StaticVectorImpl<int, 5,
arrow::internal::SmallVectorStorage<int, 5> >’} to itself [-Wself-move]
../src/arrow/util/small_vector_test.cc:417:22: note: remove ‘std::move’ call
../src/arrow/util/small_vector_test.cc: In instantiation of ‘void
arrow::internal::TestSmallStaticVector<Param>::CheckMove(bool) [with long
unsigned int N = 5; Param =
arrow::internal::VectorIntLikeParam<arrow::internal::StaticVectorTraits, int>]’:
../src/arrow/util/small_vector_test.cc:423:38: required from ‘void
arrow::internal::TestSmallStaticVector<Param>::TestMove() [with Param =
arrow::internal::VectorIntLikeParam<arrow::internal::StaticVectorTraits, int>]’
../src/arrow/util/small_vector_test.cc:762:57: required from ‘void
arrow::internal::TestSmallStaticVector_Move_Test<gtest_TypeParam_>::TestBody()
[with gtest_TypeParam_ =
arrow::internal::VectorIntLikeParam<arrow::internal::StaticVectorTraits, int>]’
../src/arrow/util/small_vector_test.cc:762:1: required from here
../src/arrow/util/small_vector_test.cc:417:22: warning: moving
‘moved_moved_ints’ of type
‘arrow::internal::TestSmallStaticVector<arrow::internal::VectorIntLikeParam<arrow::internal::StaticVectorTraits,
int> >::IntVectorType<5>’ {aka ‘arrow::internal::StaticVectorImpl<int, 5,
arrow::internal::StaticVectorStorage<int, 5, false> >’} to itself [-Wself-move]
../src/arrow/util/small_vector_test.cc:417:22: note: remove ‘std::move’ call
../src/arrow/util/small_vector_test.cc: In instantiation of ‘void
arrow::internal::TestSmallStaticVector<Param>::CheckMove(bool) [with long
unsigned int N = 2; Param =
arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits,
arrow::internal::HeapInt>]’:
../src/arrow/util/small_vector_test.cc:423:38: required from ‘void
arrow::internal::TestSmallStaticVector<Param>::TestMove() [with Param =
arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits,
arrow::internal::HeapInt>]’
../src/arrow/util/small_vector_test.cc:762:57: required from ‘void
arrow::internal::TestSmallStaticVector_Move_Test<gtest_TypeParam_>::TestBody()
[with gtest_TypeParam_ =
arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits,
arrow::internal::HeapInt>]’
../src/arrow/util/small_vector_test.cc:762:1: required from here
../src/arrow/util/small_vector_test.cc:417:22: warning: moving
‘moved_moved_ints’ of type
‘arrow::internal::TestSmallStaticVector<arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits,
arrow::internal::HeapInt> >::IntVectorType<2>’ {aka
‘arrow::internal::StaticVectorImpl<arrow::internal::HeapInt, 2,
arrow::internal::SmallVectorStorage<arrow::internal::HeapInt, 2> >’} to itself
[-Wself-move]
../src/arrow/util/small_vector_test.cc:417:22: note: remove ‘std::move’ call
../src/arrow/util/small_vector_test.cc: In instantiation of ‘void
arrow::internal::TestSmallStaticVector<Param>::CheckMove(bool) [with long
unsigned int N = 5; Param =
arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits,
arrow::internal::HeapInt>]’:
../src/arrow/util/small_vector_test.cc:424:17: required from ‘void
arrow::internal::TestSmallStaticVector<Param>::TestMove() [with Param =
arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits,
arrow::internal::HeapInt>]’
../src/arrow/util/small_vector_test.cc:762:57: required from ‘void
arrow::internal::TestSmallStaticVector_Move_Test<gtest_TypeParam_>::TestBody()
[with gtest_TypeParam_ =
arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits,
arrow::internal::HeapInt>]’
../src/arrow/util/small_vector_test.cc:762:1: required from here
../src/arrow/util/small_vector_test.cc:417:22: warning: moving
‘moved_moved_ints’ of type
‘arrow::internal::TestSmallStaticVector<arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits,
arrow::internal::HeapInt> >::IntVectorType<5>’ {aka
‘arrow::internal::StaticVectorImpl<arrow::internal::HeapInt, 5,
arrow::internal::SmallVectorStorage<arrow::internal::HeapInt, 5> >’} to itself
[-Wself-move]
../src/arrow/util/small_vector_test.cc:417:22: note: remove ‘std::move’ call
../src/arrow/util/small_vector_test.cc: In instantiation of ‘void
arrow::internal::TestSmallStaticVector<Param>::CheckMove(bool) [with long
unsigned int N = 5; Param =
arrow::internal::VectorIntLikeParam<arrow::internal::StaticVectorTraits,
arrow::internal::HeapInt>]’:
../src/arrow/util/small_vector_test.cc:423:38: required from ‘void
arrow::internal::TestSmallStaticVector<Param>::TestMove() [with Param =
arrow::internal::VectorIntLikeParam<arrow::internal::StaticVectorTraits,
arrow::internal::HeapInt>]’
../src/arrow/util/small_vector_test.cc:762:57: required from ‘void
arrow::internal::TestSmallStaticVector_Move_Test<gtest_TypeParam_>::TestBody()
[with gtest_TypeParam_ =
arrow::internal::VectorIntLikeParam<arrow::internal::StaticVectorTraits,
arrow::internal::HeapInt>]’
../src/arrow/util/small_vector_test.cc:762:1: required from here
../src/arrow/util/small_vector_test.cc:417:22: warning: moving
‘moved_moved_ints’ of type
‘arrow::internal::TestSmallStaticVector<arrow::internal::VectorIntLikeParam<arrow::internal::StaticVectorTraits,
arrow::internal::HeapInt> >::IntVectorType<5>’ {aka
‘arrow::internal::StaticVectorImpl<arrow::internal::HeapInt, 5,
arrow::internal::StaticVectorStorage<arrow::internal::HeapInt, 5, true> >’} to
itself [-Wself-move]
../src/arrow/util/small_vector_test.cc:417:22: note: remove ‘std::move’ call
../src/arrow/util/small_vector_test.cc: In instantiation of ‘void
arrow::internal::TestSmallStaticVector<Param>::CheckMove(bool) [with long
unsigned int N = 2; Param =
arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits,
arrow::MoveOnlyDataType>]’:
../src/arrow/util/small_vector_test.cc:423:38: required from ‘void
arrow::internal::TestSmallStaticVector<Param>::TestMove() [with Param =
arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits,
arrow::MoveOnlyDataType>]’
../src/arrow/util/small_vector_test.cc:762:57: required from ‘void
arrow::internal::TestSmallStaticVector_Move_Test<gtest_TypeParam_>::TestBody()
[with gtest_TypeParam_ =
arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits,
arrow::MoveOnlyDataType>]’
../src/arrow/util/small_vector_test.cc:762:1: required from here
../src/arrow/util/small_vector_test.cc:417:22: warning: moving
‘moved_moved_ints’ of type
‘arrow::internal::TestSmallStaticVector<arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits,
arrow::MoveOnlyDataType> >::IntVectorType<2>’ {aka
‘arrow::internal::StaticVectorImpl<arrow::MoveOnlyDataType, 2,
arrow::internal::SmallVectorStorage<arrow::MoveOnlyDataType, 2> >’} to itself
[-Wself-move]
../src/arrow/util/small_vector_test.cc:417:22: note: remove ‘std::move’ call
../src/arrow/util/small_vector_test.cc: In instantiation of ‘void
arrow::internal::TestSmallStaticVector<Param>::CheckMove(bool) [with long
unsigned int N = 5; Param =
arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits,
arrow::MoveOnlyDataType>]’:
../src/arrow/util/small_vector_test.cc:424:17: required from ‘void
arrow::internal::TestSmallStaticVector<Param>::TestMove() [with Param =
arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits,
arrow::MoveOnlyDataType>]’
../src/arrow/util/small_vector_test.cc:762:57: required from ‘void
arrow::internal::TestSmallStaticVector_Move_Test<gtest_TypeParam_>::TestBody()
[with gtest_TypeParam_ =
arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits,
arrow::MoveOnlyDataType>]’
../src/arrow/util/small_vector_test.cc:762:1: required from here
../src/arrow/util/small_vector_test.cc:417:22: warning: moving
‘moved_moved_ints’ of type
‘arrow::internal::TestSmallStaticVector<arrow::internal::VectorIntLikeParam<arrow::internal::SmallVectorTraits,
arrow::MoveOnlyDataType> >::IntVectorType<5>’ {aka
‘arrow::internal::StaticVectorImpl<arrow::MoveOnlyDataType, 5,
arrow::internal::SmallVectorStorage<arrow::MoveOnlyDataType, 5> >’} to itself
[-Wself-move]
```
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
