RE: [PATCH 10/11] drm/i915/color: Do not pre-load LUTs with DB registers

Wed, 14 May 2025 04:46:36 -0700 


> -----Original Message-----
> From: Borah, Chaitanya Kumar <[email protected]>
> Sent: Tuesday, April 8, 2025 4:30 PM
> To: [email protected]; [email protected]
> Cc: [email protected]; Shankar, Uma <[email protected]>;
> Borah, Chaitanya Kumar <[email protected]>; Manna, Animesh
> <[email protected]>
> Subject: [PATCH 10/11] drm/i915/color: Do not pre-load LUTs with DB registers
> 
> Since Double Buffered LUT registers can be written in active region no need to
> preload them.

Looks Good to me.
Reviewed-by: Uma Shankar <[email protected]>

> Signed-off-by: Chaitanya Kumar Borah <[email protected]>
> ---
>  drivers/gpu/drm/i915/display/intel_color.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_color.c
> b/drivers/gpu/drm/i915/display/intel_color.c
> index ac00b86798fb..671db6926e4c 100644
> --- a/drivers/gpu/drm/i915/display/intel_color.c
> +++ b/drivers/gpu/drm/i915/display/intel_color.c
> @@ -2041,9 +2041,13 @@ void intel_color_wait_commit(const struct
> intel_crtc_state *crtc_state)  static bool intel_can_preload_luts(struct
> intel_atomic_state *state,
>                                  struct intel_crtc *crtc)
>  {
> +     struct intel_display *display = to_intel_display(state);
>       const struct intel_crtc_state *old_crtc_state =
>               intel_atomic_get_old_crtc_state(state, crtc);
> 
> +     if (HAS_DOUBLE_BUFFERED_LUT(display))
> +             return false;
> +
>       return !old_crtc_state->post_csc_lut &&
>               !old_crtc_state->pre_csc_lut;
>  }
> --
> 2.25.1

























					Reply via email to