andygrove commented on code in PR #16350:
URL: https://github.com/apache/datafusion/pull/16350#discussion_r2138449102
##########
datafusion/spark/src/function/math/hex.rs:
##########
@@ -192,7 +195,7 @@ pub fn spark_hex(args: &[ColumnarValue]) ->
Result<ColumnarValue, DataFusionErro
let hexed: StringArray = array
.iter()
- .map(|v| v.map(hex_bytes).transpose())
+ .map(|v| v.map(|b| hex_bytes(b, true)).transpose())
Review Comment:
The change to the hex function did not cause any test failures ... does this
mean we are missing some tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
