rishvin commented on code in PR #16350:
URL: https://github.com/apache/datafusion/pull/16350#discussion_r2138597475
##########
datafusion/spark/src/function/math/hex.rs:
##########
@@ -192,7 +195,7 @@ pub fn spark_hex(args: &[ColumnarValue]) ->
Result<ColumnarValue, DataFusionErro
let hexed: StringArray = array
.iter()
- .map(|v| v.map(hex_bytes).transpose())
+ .map(|v| v.map(|b| hex_bytes(b, true)).transpose())
Review Comment:
We do have [hex related test
cases](https://github.com/rishvin/datafusion-comet/blob/1b1d6185ede9175887de1e9ec7f48422c2a64a10/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala#L1424)
in Comet but they seems to be passing.
Looks like this is happening because Comet has its own
[hex-function](https://github.com/rishvin/datafusion-comet/blob/1b1d6185ede9175887de1e9ec7f48422c2a64a10/native/spark-expr/src/comet_scalar_funcs.rs#L91-L91),
for which we call
[hex_bytes](https://github.com/rishvin/datafusion-comet/blob/1b1d6185ede9175887de1e9ec7f48422c2a64a10/native/spark-expr/src/math_funcs/hex.rs#L87-L87).
But for hex-bytes lower case is set to
[false](https://github.com/rishvin/datafusion-comet/blob/1b1d6185ede9175887de1e9ec7f48422c2a64a10/native/spark-expr/src/math_funcs/hex.rs#L61).
Hence, no failure.
So, looks like the Datafusion's hex functionality is not getting leveraged
and Comet is handling this on its own, hence we did not see regression on the
Comet test-suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
