NoahKusaba commented on code in PR #2474: URL: https://github.com/apache/datafusion-ballista/pull/2474#discussion_r4077374825
########## docs/source/contributors-guide/development.md: ########## @@ -202,6 +202,13 @@ A release branch therefore only ever depends on published crates. Each `rev` bum that ports any DataFusion API changes, refreshes affected golden files, and keeps `cargo test` and `cargo clippy --all-targets --workspace -- -D warnings` green. +`dev/update_datafusion_versions.py` rewrites the `datafusion*` entries across the workspace for you. Review Comment: Good catch, and thanks for actually running it. You're right: the pins all live in `[workspace.dependencies]`, which the script never reads, and its crate list is still DataFusion's own. I've dropped the doc from this PR so it doesn't send anyone to a script that doesn't work, and I'll fix the script in a follow-up. ########## .gitignore: ########## @@ -18,71 +18,28 @@ apache-rat-*.jar rat.txt filtered_rat.txt -arrow-src.tar -arrow-src.tar.gz CHANGELOG.md.bak Cargo.toml.bak data/ # Compiled source -*.a -*.dll -*.o *.py[ocd] -*.so -*.so.* -*.bundle -*.dylib -.build_cache_dir -dependency-reduced-pom.xml -MANIFEST -compile_commands.json -build.ninja -# Generated Visual Studio files -*.vcxproj -*.vcxproj.* -*.sln *.iml -# Linux perf sample data -perf.data Review Comment: Fair point, restored. That made me recheck the other removals for the same thing, and I'd also dropped `python/examples/.ipynb_checkpoints`, which isn't Arrow-specific either since we ship notebooks there. It's back too, as `.ipynb_checkpoints/` so it covers any directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
